Preserving gl3d trace ordering on restyle #1466
Merged
+808
−737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove deeply nested trees - split suite into multiple root-level 'describe's - reduce modebar delay
- ensuring that visibility toggles don't reorder the traces
| mockCopy.layout.showlegend = true; | ||
| function _hover() { | ||
| mouseEventScatter3d('mouseover'); | ||
| return delay; |
|
Looks good to me, after that small change in the test 💃 That said, I'd like to leave #1267 open, because it points to a bigger problem. I'll update the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using a similar technique to #1444
Bonus: this PR removes the many deeply nested 🎄 in
gl_plot_interact_test.js.EDIT: See #1267 for more on this issue.