fix removal of last shape or annotation #1451
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Mar 8, 2017
| @@ -69,7 +69,7 @@ function drawOne(gd, index) { | |||
| fullLayout._infolayer.selectAll('.annotation[data-index="' + index + '"]').remove(); | |||
|
|
|||
| // remember a few things about what was already there, | |||
| var optionsIn = layout.annotations[index], | |||
| var optionsIn = (layout.annotations || [])[index], | |||
There was a problem hiding this comment.
Ha. I'm looking forward to making annotations and shapes updates d3-idiomatic. These user / full container double standard headaches will be gone!
etpinard
reviewed
Mar 8, 2017
| .then(function() { | ||
| return Plotly.relayout(gd, {'shapes[0]': getRandomShape()}); | ||
| }) | ||
| .then(function() { |
There was a problem hiding this comment.
Nice tests! Annotations and shapes are getting nicely 🔒 ed down.
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the last shape or annotation led to an error in
drawOne. Images don't havedrawOneso are immune to this problem. Ironically, images are also the only one that previously had a test for it. Someday we go d3-idiomatic and get rid ofdrawOneentirely...cc @etpinard - there's one more bug I've uncovered while testing in the workspace, will make another PR for it then may need yet another patch release.