Fixup for Axes.expand in the early return case
#1425
Merged
+42
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rm obsolete _needsExpand - mock with `ax.autorange: true`
etpinard
commented
Feb 27, 2017
| var needsAutorange = (ax.autorange || Lib.nestedProperty(ax, 'rangeslider.autorange')); | ||
| var needsAutorange = ( | ||
| ax.autorange || | ||
| !!Lib.nestedProperty(ax, 'rangeslider.autorange').get() |
There was a problem hiding this comment.
Even if ax.rangeslider is undefined, Lib.nestedProperty(ax, 'rangeslider.autorange') return an object (which is of course truthy) - which made needsAutorange always be truthy, removing the early return 🐎 path.
There was a problem hiding this comment.
haha I've made exactly that mistake more than once...
etpinard
commented
Feb 27, 2017
| c2l: Number, | ||
| type: 'linear', | ||
| _length: 100, | ||
| _m: 1, | ||
| _needsExpand: true |
There was a problem hiding this comment.
That's an artefact that of the old range slider + autorange implementation that should've been taken out in cebc31c
My mistake.
|
💃 |
etpinard
changed the title
Axes.expand in the early caseAxes.expand in the early return case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for commit cebc31c part of the multiple range slider PR #1355