Scattermapbox line trailing gaps #1421
Merged
+38
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Feb 24, 2017
| var lineCoords = [ | ||
| [[10, 20], [20, 20], [30, 10]], | ||
| [[20, 10], [10, 20]] | ||
| ]; |
There was a problem hiding this comment.
Previously, this was:
var lineCoords = [
[[10, 20], [20, 20], [30, 10]],
[[20, 10], [10, 20]].
[]
];which lead to an invalid GeoJSON and made mapbox-gl fail.
There was a problem hiding this comment.
Great. I thought this would be a pretty easy fix. Just to confirm, I assume it will also handle [10, '20', 30, 20, null, 20, 10, null, null] without problems?
There was a problem hiding this comment.
I assume it will also handle [10, '20', 30, 20, null, 20, 10, null, null] without problems?
Yes it does: 1a22beb
| @@ -365,6 +365,23 @@ describe('scattermapbox convert', function() { | |||
| expect(actualText).toEqual(['A', 'B', 'C', 'F', '']); | |||
| }); | |||
|
|
|||
| it('for lines traces with trailing gaps', function() { | |||
There was a problem hiding this comment.
same comment as #1414 (comment) - is this an intentional pattern now?
There was a problem hiding this comment.
Yes, much better to my eye - thanks!
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1418
easy. cc @rreusser