Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gl3d surface opacity scaling #1415

Merged
merged 2 commits into from
Feb 24, 2017
Merged

Fix gl3d surface opacity scaling #1415

merged 2 commits into from
Feb 24, 2017
+1 −7

Conversation

etpinard
Copy link
Contributor

fixes #1206

Strangely, trace opacity was scaled by 0.25 before being passed to gl-surface3d :

image

Removing this scaling gives:

gifrecord_2017-02-24_120430

which I believe looks like the desired behavior @cldougl can you confirm?

@etpinard etpinard added status: reviewable bug something broken labels Feb 24, 2017
@etpinard etpinard added this to the 1.24.0 milestone Feb 24, 2017
@cldougl
Copy link
Member

cldougl commented Feb 24, 2017

@etpinard yep exactly! Now the decrease appears to be linear/increments as expected.

@etpinard etpinard merged commit 4e4deb2 into master Feb 24, 2017
@etpinard etpinard deleted the gl3d-surface-opacity branch February 24, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Opacity for 3D plots doesn't behave as expected
2 participants
@etpinard @cldougl