Finance trace editable legend fix #1349
Merged
+85
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Feb 1, 2017
| editNode.dispatchEvent(new window.FocusEvent('focus')); | ||
|
|
||
| editNode.textContent = newText; | ||
| editNode.dispatchEvent(new window.FocusEvent('focus')); |
There was a problem hiding this comment.
I learned something new -> https://developer.mozilla.org/en-US/docs/Web/API/FocusEvent
There was a problem hiding this comment.
which is used to invoke the makeEditable handlers.
|
Gotta love the 1-line fix with 76 lines of tests! 💃 |
in finance legend item edit test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1329
In #1020 (more precisely in fbb299b) a custom finance trace
editable: truelegend item handler was added to ensure that editing legend text would propagate to the correct finance trace. Unfortunately, the relevant attribute name changed since then, breaking the behavior. Testing this particulareditable: trueisn't trivial hence why I left it out of #1020.In this PR, I make sure to 🔒 this behavior down.