fixes 3d thumbnail clone when no xaxis in scene #1327
Merged
+53
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| extendFlat(newLayout[sceneId].xaxis || {}, axesImageOverride); | ||
| extendFlat(newLayout[sceneId].yaxis || {}, axesImageOverride); | ||
| extendFlat(newLayout[sceneId].zaxis || {}, axesImageOverride); |
There was a problem hiding this comment.
|| {} is unnecessary here (and would have been confusingly useless by itself)
I'd probably also do var scene = newLayout[sceneIds[i]] instead of var sceneId = sceneIds[i] to be more concise, but that's more of a style issue.
bpostlethwaite
force-pushed
the
fix-Thumbnail-Clone
branch
from
45c0816 to
33e60ef
Compare
|
@alexcjohnson changes made ready for review |
|
💃 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test case that now (should) be passing was failing before this fix. This impacted Plotly image server thumbnail generation.