gl2d non-visible traces improvements #1300
Merged
+86
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to optimize 'visible' toggling - and fix a few bugs with data-less scattergl traces
- to make sure they don't make Plotly.plot crash
etpinard
changed the title
| "x": [] | ||
| }, | ||
| { | ||
| "type": "scattergl" |
There was a problem hiding this comment.
and one each that has data but visible: false || 'legendonly'?
|
How hard would it be to test toggling one of these traces on/off, maybe by clicking the legend? Might be overkill given the tests you do have... |
Not hard. At least it we only test the corresponding We already have one for gl3d here. I added one for gl2d in a587f8d |
|
Those tests are fine. No need to do an actual click. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1298
Previously scattergl traces with
visible: falseorvisible: 'legendonly'weren't filtered out of theconvertstep where several methods assumed non-emptytrace.xandtrace.y.This PR add a third scattergl update path (along side the current fancy and fast paths) for
visible !== truetraces where gl-vis objects are updated withFloat62Array(0)as data.