Add event and test for updatemenus events #1128
Merged
+27
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Nov 9, 2016
| @@ -299,6 +299,8 @@ function drawButtons(gd, gHeader, gButton, menuOpts) { | |||
| setActive(gd, menuOpts, buttonOpts, gHeader, gButton, buttonIndex); | |||
|
|
|||
| Plots.executeAPICommand(gd, buttonOpts.method, buttonOpts.args); | |||
|
|
|||
| gd.emit('plotly_buttonclicked', {menu: menuOpts, button: buttonOpts, active: menuOpts.active}); | |||
There was a problem hiding this comment.
Some people have been asking for an event on legend item click.
I'm not suggesting we should have a lone event for updatemenu button click and legend item click, but we should make sure the event names are consistent.
I'm thinking plotly_buttonclicked and plotly_legendclick, unless someone find the two confusing.
|
💃 |
GeorgeGhiottone
pushed a commit
to GeorgeGhiottone/plotly.js
that referenced
this pull request
Nov 30, 2016
GeorgeGhiottone
pushed a commit
to GeorgeGhiottone/plotly.js
that referenced
this pull request
Dec 1, 2016
GeorgeGhiottone
pushed a commit
to GeorgeGhiottone/plotly.js
that referenced
this pull request
Dec 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an event for updatemenus. There's really only one event:
plotly_buttonclicked. It sends the menu, the button, and the index of the active button. The analogous open/close menu options didn't seem so relevant for this case.