Filter fixes #1062
Merged
Filter fixes #1062
+253
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- so that findArrayAttributes can track arrayOk attribute within transforms containers.
- use auto-typed axis data-to-calc method to filter by target array
etpinard
commented
Oct 20, 2016
| var transform = transforms[i]; | ||
|
|
||
| stack = ['transforms[' + i + ']']; | ||
| exports.crawl(transform._module.attributes, callback, 1); |
There was a problem hiding this comment.
Loop through transform container found in the trace, use the transform module attributes declaration to determine which attributes are data_array or arrayOk.
etpinard
commented
Oct 20, 2016
| }] | ||
| })]); | ||
|
|
||
| expect(out[0].x).toEqual([-1, 1, 2]); | ||
| expect(out[0].y).toEqual([2, 2, 3]); | ||
| expect(out[0].ids).toEqual(['n1', 'p1', 'p2']); | ||
| }); | ||
|
|
||
| describe('filters should handle array *target* values', function() { |
There was a problem hiding this comment.
@chriddyp please review the lines ⏬
thank you.
etpinard
commented
Oct 20, 2016
| layout: {} | ||
| }; | ||
|
|
||
| Plots.supplyDefaults(mockGd); |
|
Oh and by the way @bpostlethwaite transform attribute are already part of the plot schema:
|
|
👍! 💃 from me! |
- for the Array.isArray(target) case
etpinard
force-pushed
the
filter-fixes
branch
from
b66ff67 to
14fd327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After first being released in
v1.18.0, we come to the conclusion that filter transforms are incompatible with plot.ly's webapp data references.So, we have no choice but to 🔪 the
filtersrcattribute and rename it'target'. A backward-compatible block has been tocleanData.Moreover, to allow filtering about arbitrary columns of data, we now allow
'target'to be an arbitrary array of data - which required a few patches to theLib.findArrayAttributes.cc @rreusser @bpostlethwaite @chriddyp