Skip to content

Scattergeo unfound country name fix #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2016
Merged

Scattergeo unfound country name fix #1046

merged 3 commits into from
Oct 18, 2016
+394 −349

Conversation

etpinard
Copy link
Contributor

fixes #1043

back to pre-1.18.0 behaviour.

Bonus:

  • merges the geo test suites into one (on-par with some newer development)
  • makes sure that geo hover labels are removed on mouse out.

@etpinard etpinard added bug something broken status: reviewable labels Oct 17, 2016
@etpinard etpinard merged commit a74b0f7 into master Oct 18, 2016
@etpinard etpinard deleted the scattergeo-country-name-fix branch October 18, 2016 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scattergeo crashing on unrecognized country names in 1.18
1 participant
@etpinard