Skip to content

no calendar on partial bundles #4883

Closed
@mattcorner

Description

@mattcorner

I am trying to get the connectgaps property to work in a React app where I use a custom plotly.js bundle to reduce the build size.

With this custom bundle which imports only Surface, connectgaps does not work.

If I use the full plotly.js bundle, the plot works properly.

See attached github repo for a simple reproduction showing the two plots side-by-side.
image
Github repo for reproduction

I presume that I either need to import something extra in the custom bundle, or that lib/Surface is missing a dependency?

Activity

archmoj

archmoj commented on May 28, 2020

@archmoj
Contributor

Thanks for reporting. Here is a codepen illustrating the bug.
That's possibly related to surface trace using a function from heatmap trace.

changed the title [-]Surface "connectgaps" not working with custom bundle[/-] [+]no calendar on partial bundle[/+] on Jun 2, 2020
archmoj

archmoj commented on Jun 2, 2020

@archmoj
Contributor

@alexcjohnson strangely there is no calendar attached to axes when using partial gl3d bundle: demo.

changed the title [-]no calendar on partial bundle[/-] [+]no calendar on partial bundles[/+] on Jun 2, 2020
archmoj

archmoj commented on Jun 2, 2020

@archmoj
Contributor

Not only gl3d but also other partial bundles e.g. gl2d & basic are also impacted by this bug: demo.

archmoj

archmoj commented on Jun 2, 2020

@archmoj
Contributor

To clarify how calendar issue is linked to surface.connectgaps issue,
calendar is undefined here when using partial bundle:

rawCoords[2][j][k] = this.getZat(j, k, data.zcalendar, sceneLayout.zaxis);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugsomething broken

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @mattcorner@archmoj

      Issue actions

        no calendar on partial bundles · Issue #4883 · plotly/plotly.js