Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

World Choropleth map issue with showcoastlines: false #3992

Closed
michaelbabyn opened this issue Jun 27, 2019 · 0 comments · Fixed by #3994
Closed

World Choropleth map issue with showcoastlines: false #3992

michaelbabyn opened this issue Jun 27, 2019 · 0 comments · Fixed by #3994
Assignees
@etpinard
Labels
bug something broken

Comments

@michaelbabyn
Copy link

michaelbabyn commented Jun 27, 2019 •
edited
Loading

Originally reported in /plotly/documentation#1378, this choropleth example doesn't load anymore due to a regression introduced in 1.48. See this codepen with layout.geo.showcoastlines: true using plotly.js 1.47.0 and the same plot using version 1.48.0 of plotly.js.

I see the following error in the console:

Uncaught (in promise) TypeError: Cannot read property 'objects' of null
    at n.getTopojsonFeatures (plotlyjs-bundle.7315e6932bed.js:1)
    at u (plotlyjs-bundle.7315e6932bed.js:1)
    at Object.e.exports [as plot] (plotlyjs-bundle.7315e6932bed.js:1)
    at Object.g.generalUpdatePerTraceModule (plotlyjs-bundle.7315e6932bed.js:1)
    at y.x.update (plotlyjs-bundle.7315e6932bed.js:1)
    at y.x.plot (plotlyjs-bundle.7315e6932bed.js:1)
    at Object.plot (plotlyjs-bundle.7315e6932bed.js:1)
    at r.drawData (plotlyjs-bundle.7315e6932bed.js:1)
    at Object.l.syncOrAsync (plotlyjs-bundle.7315e6932bed.js:1)
    at i (plotlyjs-bundle.7315e6932bed.js:1)
@michaelbabyn michaelbabyn mentioned this issue Jun 27, 2019
Closed
@etpinard etpinard added the bug something broken label Jun 27, 2019
@etpinard etpinard self-assigned this Jun 27, 2019
etpinard added a commit that referenced this issue Jun 28, 2019
@etpinard
fix #3992 - fetch topojson when 1+ trace(s) has locationmode
b7dac75 
- so that `_module.plot` can find the relevant polygon and/or
  centroids, even though no base layers is drawn
@etpinard etpinard mentioned this issue Jun 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fetch topojson when 1+ trace(s) has locationmode plotly/plotly.js
2 participants
@etpinard @michaelbabyn