Skip to content

Matching date axes don't autoscale correctly #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Toumetis opened this issue Apr 15, 2019 · 1 comment · Fixed by #3772
Closed

Matching date axes don't autoscale correctly #3770

Toumetis opened this issue Apr 15, 2019 · 1 comment · Fixed by #3772
Labels
bug something broken

Comments

@Toumetis
Copy link

Toumetis commented Apr 15, 2019

doAutoRangeAndConstraints attempts to take the min/max of the string representation, breaking autorange / reset axis.

https://codepen.io/Toumetis/pen/eoGogx

My fix is here, please review. Toumetis@dc9b25e

@etpinard
Copy link
Contributor

Thanks very much for the report!

At first glance, your commit looks right. Would you mind making a PR? For bonus point, you could try adding a data/layout mock to lock down the behavior (see https://github.com/plotly/plotly.js/tree/master/test/image#c-generate-or-update-existing-baseline-image for more info)

@etpinard etpinard added the bug something broken label Apr 15, 2019
Toumetis pushed a commit to Toumetis/plotly.js that referenced this issue Apr 15, 2019
Toumetis pushed a commit to Toumetis/plotly.js that referenced this issue Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants