Skip to content

Add Mucho Marker example to docs #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add Mucho Marker example to docs #16

wants to merge 2 commits into from

Conversation

etpinard
Copy link
Contributor

@theengineear
Copy link
Contributor

Awesome! It's clear to me how I would add dots or not fill markers, but maybe you could just do a few examples of that on the right? I.e., put another column at the right with a few examples of using -open-dot to make it easier for users to get that caption?

@etpinard
Copy link
Contributor Author

I'll see what I can do.

This layout is pretty much saturated for a 500px X 500px docs figure.

@etpinard
Copy link
Contributor Author

new fig --> https://plot.ly/~etpinard/435/500/500/

@theengineear
Copy link
Contributor

yup! that's perfect!

🐖

@etpinard
Copy link
Contributor Author

... I'd love to get 👍 from @alexander-daniel or @chriddyp before merging this.

@alexander-daniel
Copy link
Contributor

🍧 delicious!

@chriddyp
Copy link
Member

is the marker number the only way to do this? if you can also supply a string, still, then I think we should include it.

@etpinard
Copy link
Contributor Author

@chriddyp correct. The corresponding marker symbol strings appear on hover.

@@ -5,5 +5,5 @@
"description": "How to make line and scatter plots in {language}. {num_examples} examples of basic and colored line and scatter plots.",
"order": ["matlab-line-and-scatter-basic",
"gg-basic-line", "gg-basic-scatter", "gg-line-scatter", "gg-alpha",
"basic-line", "line-scatter", "line-style"]
"basic-line", "line-scatter", "line-style", "marker-symbols"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it confusing that this will be peoples first introduction to setting arrays for attributes inside a trace? previously, we introduced this concept in the bubble charts section. people might think that to set a trace to square symbols , you have to set a symbol array, and set every single element in that array to "square". .. you know what I mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another solution might be to include an example with customized per -trace properties, e.g. color, symbol, and then include a "prepend" or "append" (cc @EnginEAR, @alex-vados) note that has a link to this example, "to see all possible marker types"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Would you recommend making 45 traces instead?

Or putting https://plot.ly/~etpinard/435/500/500/ is bubble-charts/ ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might also want to include an example like (or identical) to the bubble charts example in "line-and-scatter" section, to show people how to set properties as an array inside a trace

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or just a few traces (5) and include a prepend section with a link to the reference section and your example of every single symbol type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alex-vados - could you wire in the prepend and append section to the docs template?

@etpinard
Copy link
Contributor Author

Hmm. Ok I'll wait for a consensus before merging this.

@etpinard
Copy link
Contributor Author

Or, to relate to #18, maybe we should have an Advanced styling section separated from Chart types with pages for color, color scales, symbols, etc ...

@theengineear
Copy link
Contributor

I think this should probably get linked elsewhere as it applies to both bubbles and line+scatter. for my 2 cents.

@theengineear
Copy link
Contributor

@etpinard, is this PR still relevant?

@etpinard
Copy link
Contributor Author

@theengineear Relevant for sure. I still think we should have this example in our docs.

That said,

  • I'll start over on a new branch once you're done modifying run.py
  • In my mind, this example should be in a different section (e.g. Advanced styling) separate from Chart types together with pages for color, color scales, symbols, etc ...

Thoughts?

@theengineear
Copy link
Contributor

Gotcha, I thought it might have gotten into documentation through a different branch. Yeah, this should definitely be in there. Perhaps a name like "Plot styling" might attract better searches though? Either way, yeah, I could foresee a number of examples getting filed there.

@etpinard
Copy link
Contributor Author

I like the sound of Plot styling.

@alexander-daniel @chriddyp Thoughts?

@etpinard
Copy link
Contributor Author

All the colorscale plots on https://plot.ly/python/heatmaps/ would better fit under Plot styling / Color scales in my mind.

@chriddyp
Copy link
Member

Plot styling! I think that's a good idea. Moving to another repo!

@chriddyp
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants