This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Upgrade Plotly.js to 1.47.0 #516
Merged
+29
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Marc-Andre-Rivet
commented
Apr 9, 2019
•
Marc-Andre-Rivet
commented
- missing 1.47.0 and 1.46.0 feature release highlights
Marc-Andre-Rivet
commented
Apr 9, 2019
| 2. Update `dash_core_components/__init__.py` plotly.js `external_url` | ||
| 3. Update `MANIFEST.in` |
There was a problem hiding this comment.
Updated manifest to use wildcard, this step is no longer required
Marc-Andre-Rivet
commented
Apr 9, 2019
| @@ -5,7 +5,7 @@ include dash_core_components/dash_core_components.dev.js.map | |||
| include dash_core_components/metadata.json | |||
| include dash_core_components/[email protected] | |||
| include dash_core_components/[email protected] | |||
| include dash_core_components/plotly-1.45.0.min.js | |||
| include dash_core_components/plotly-*.min.js | |||
There was a problem hiding this comment.
Using wildcard like here https://github.com/plotly/dash-renderer/blob/master/MANIFEST.in
alexcjohnson
approved these changes
Apr 9, 2019
|
kinda weird percy diffs - just a bunch of new whitespace at the bottom of the page. I'm going to guess it's just percy doing something weird with the extra internal structure of a plotly.js graph added in plotly/plotly.js#3589... looks fine locally, I approved the diff. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.