Export internal CameraShaderParams class which is currently required by the Editor #7168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this needed by the Editor? |
|
This class is used by the shader generator, and Editor has a case where it manually generates depth shader. Not a good solution, but that's what it is. I used to use RenderParams, but I removed those and forgot to expose this new way. |
|
If I approve this, can we consider this temporary with a view to a better solution based on public API in the future? |
Of course. |
willeastcott
approved these changes
Dec 4, 2024
mvaligursky
added a commit
that referenced
this pull request
Dec 4, 2024
…by the Editor (#7168) Co-authored-by: Martin Valigursky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not exposed in docs