Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tiup: hide password when record history #2425

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Jun 5, 2024

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish June 5, 2024 03:09
Copy link
Contributor

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.09%. Comparing base (50abc4f) to head (857cbd3).
Report is 7 commits behind head on master.

Current head 857cbd3 differs from pull request most recent head de0851f

Please upload reports for the commit de0851f to get more accurate results.

Files Patch % Lines
pkg/cluster/manager/upgrade.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2425      +/-   ##
==========================================
+ Coverage   50.14%   55.09%   +4.95%     
==========================================
  Files         333      334       +1     
  Lines       35867    35920      +53     
==========================================
+ Hits        17984    19789    +1805     
+ Misses      15521    13756    -1765     
- Partials     2362     2375      +13     
Flag Coverage Δ
unittest 21.74% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang merged commit cd22e72 into pingcap:master Jun 5, 2024
18 of 19 checks passed
@kaaaaaaang kaaaaaaang added this to the v1.16.0 milestone Jun 26, 2024
@kaaaaaaang kaaaaaaang changed the title hide password hide password when record history Jun 26, 2024
@kaaaaaaang kaaaaaaang changed the title hide password when record history tiup: hide password when record history Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants