-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix TLS configs for tiproxy #2356
Conversation
Signed-off-by: xhe <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
- Coverage 55.43% 55.42% -0.01%
==========================================
Files 329 329
Lines 34838 34845 +7
==========================================
Hits 19310 19310
- Misses 13216 13223 +7
Partials 2312 2312
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9b5ee60
to
c119143
Compare
This reverts commit a6f673f. Signed-off-by: xhe <[email protected]>
/lgtm |
/approve |
Signed-off-by: xhe <[email protected]>
@xhebox: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
/approve |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
server-tls
of tidb is manually specified, so does tiproxy'sserver-tls
. Instead, for newer tiproxy,server-http-tls
should be specified.topo.GlobalOptions.TLSEnabled
is not passed tosetTLSConfig
.schema://
and be consistent with tidbCheck List
Tests
Code changes
Side effects
Related changes
Release notes: