-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Fix TiFlash config not working #2190
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
+ Coverage 50.73% 55.77% +5.04%
==========================================
Files 318 318
Lines 33459 33465 +6
==========================================
+ Hits 16973 18662 +1689
+ Misses 14453 12562 -1891
- Partials 2033 2241 +208
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 78 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 3775314
|
@breezewish: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
db78d3c
to
dcfd8a0
Compare
bafc4f5
to
18295e6
Compare
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 501b77e
|
What problem does this PR solve?
In previous refines there was a mistake.
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: