Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Fix TiFlash config not working #2190

Merged
merged 4 commits into from
Apr 26, 2023

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

In previous refines there was a mistake.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kaaaaaaang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and lucklove April 25, 2023 02:20
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +5.04 🎉

Comparison is base (59930c2) 50.73% compared to head (299c8f7) 55.77%.

❗ Current head 299c8f7 differs from pull request most recent head 501b77e. Consider uploading reports for the commit 501b77e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2190      +/-   ##
==========================================
+ Coverage   50.73%   55.77%   +5.04%     
==========================================
  Files         318      318              
  Lines       33459    33465       +6     
==========================================
+ Hits        16973    18662    +1689     
+ Misses      14453    12562    -1891     
- Partials     2033     2241     +208     
Flag Coverage Δ
cluster 44.41% <ø> (+8.42%) ⬆️
dm 26.08% <ø> (+0.07%) ⬆️
playground 15.45% <100.00%> (+0.03%) ⬆️
tiup 16.01% <ø> (ø)
unittest 22.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/main.go 60.20% <100.00%> (+2.30%) ⬆️
components/playground/playground.go 50.83% <100.00%> (-0.11%) ⬇️

... and 78 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 3775314

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 25, 2023

@breezewish: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CLAassistant
Copy link

CLAassistant commented Apr 25, 2023

CLA assistant check
All committers have signed the CLA.

@breezewish breezewish force-pushed the wenxuan/fix-tiflash-config branch from db78d3c to dcfd8a0 Compare April 26, 2023 02:51
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 26, 2023
@kaaaaaaang kaaaaaaang force-pushed the wenxuan/fix-tiflash-config branch from bafc4f5 to 18295e6 Compare April 26, 2023 06:07
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 501b77e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 035b6af into master Apr 26, 2023
@ti-chi-bot ti-chi-bot bot deleted the wenxuan/fix-tiflash-config branch April 26, 2023 08:23
@kaaaaaaang kaaaaaaang added this to the 1.12.2 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants