Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: include '--comments' in mysql command line arguments #2187

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Apr 19, 2023

What problem does this PR solve?

close #2186

What is changed and how it works?

It just adds --comments to the output to be used for running the mysql command line tool.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    ./bin/tidb-playground and verify output when cluster is ready.

Code changes

  • output text change only

Side effects

  • none

Related changes

  • none

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 19, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 19, 2023
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 24, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 908ab26

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit ff56036 into pingcap:master Apr 24, 2023
@kaaaaaaang kaaaaaaang added this to the 1.12.2 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playground: '--comments' is no longer suggested as option to mysql command line connection
4 participants