Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cannot prune/scale-in tikv when use ipv6 #2180

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

nexustar
Copy link
Collaborator

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kaaaaaaang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from lucklove and srstack April 15, 2023 17:07
@nexustar nexustar changed the title ipv6 fix [Draft] ipv6 fix Apr 15, 2023
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Patch coverage: 82.14% and project coverage change: -0.05 ⚠️

Comparison is base (8fe14ca) 56.24% compared to head (aa8c894) 56.19%.

❗ Current head aa8c894 differs from pull request most recent head c2cfc0e. Consider uploading reports for the commit c2cfc0e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2180      +/-   ##
==========================================
- Coverage   56.24%   56.19%   -0.05%     
==========================================
  Files         318      318              
  Lines       33452    33460       +8     
==========================================
- Hits        18812    18800      -12     
- Misses      12399    12420      +21     
+ Partials     2241     2240       -1     
Flag Coverage Δ
cluster 45.02% <82.14%> (-0.05%) ⬇️
dm 26.04% <3.57%> (-0.03%) ⬇️
playground 15.46% <0.00%> (-0.02%) ⬇️
tiup 16.03% <0.00%> (+0.02%) ⬆️
unittest 22.77% <13.33%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/pump.go 62.72% <0.00%> (-4.14%) ⬇️
pkg/cluster/spec/drainer.go 56.14% <50.00%> (ø)
pkg/cluster/operation/destroy.go 59.54% <60.00%> (-0.63%) ⬇️
pkg/cluster/operation/scale_in.go 49.53% <85.71%> (-3.45%) ⬇️
pkg/cluster/api/pdapi.go 52.11% <100.00%> (+0.08%) ⬆️
pkg/cluster/operation/upgrade.go 47.14% <100.00%> (ø)
pkg/cluster/spec/validate.go 92.61% <100.00%> (+0.01%) ⬆️
pkg/utils/utils.go 82.93% <100.00%> (+2.93%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kaaaaaaang kaaaaaaang changed the title [Draft] ipv6 fix fix cannot prune/scale-in tikv when use ipv6 Apr 17, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 17, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c2cfc0e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 17, 2023
@ti-chi-bot ti-chi-bot merged commit 423d5ef into pingcap:master Apr 17, 2023
@kaaaaaaang kaaaaaaang added this to the 1.12.2 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants