Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: delete !#$%&= from init password #2136

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

nexustar
Copy link
Collaborator

@nexustar nexustar commented Mar 9, 2023

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AstroProfundis

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@nexustar nexustar closed this Mar 9, 2023
@ti-chi-bot ti-chi-bot requested review from breezewish and srstack March 9, 2023 09:17
@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2023
@kaaaaaaang kaaaaaaang reopened this Mar 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: +30.85 🎉

Comparison is base (7fcde36) 25.57% compared to head (080ca32) 56.42%.

❗ Current head 080ca32 differs from pull request most recent head aaea1e1. Consider uploading reports for the commit aaea1e1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2136       +/-   ##
===========================================
+ Coverage   25.57%   56.42%   +30.85%     
===========================================
  Files         286      313       +27     
  Lines       30076    33241     +3165     
===========================================
+ Hits         7691    18754    +11063     
+ Misses      21525    12258     -9267     
- Partials      860     2229     +1369     
Flag Coverage Δ
cluster 45.08% <ø> (?)
dm 26.22% <ø> (?)
playground 15.29% <ø> (?)
tiup 15.93% <ø> (ø)
unittest 22.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/crypto/rand/passwd.go 75.00% <ø> (ø)
components/playground/instance/pump.go 0.00% <0.00%> (ø)
components/playground/instance/instance.go 48.57% <0.00%> (ø)
components/playground/instance/tidb.go 89.66% <0.00%> (ø)
pkg/cluster/operation/upgrade.go 47.14% <0.00%> (ø)
components/dm/task/update_dm_meta.go 87.76% <0.00%> (ø)
pkg/cluster/operation/scale_in.go 52.98% <0.00%> (ø)
pkg/cluster/operation/action.go 64.55% <0.00%> (ø)
...onents/playground/instance/tiflash_proxy_config.go 80.00% <0.00%> (ø)
components/playground/instance/pd.go 74.63% <0.00%> (ø)
... and 220 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nexustar nexustar added this to the 1.12.0 milestone Mar 9, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 13, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: aaea1e1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 13, 2023
@kaaaaaaang
Copy link
Collaborator

/merge

@ti-chi-bot ti-chi-bot merged commit 72cbdf4 into pingcap:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid special characters in root password generation with --init command
5 participants