Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/minikube: update documentation of minikube installation #471

Merged
merged 3 commits into from
May 9, 2019

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Testing current documentation of Minikube installation and keep it up to date.

What is changed and how it works?

Tested all instructions in the Minikube installation documentation on a Dell XPS13 9360 laptop with latest ArchLinux and VirtualBox, updated them to fit testing results and added some detailed notes.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has documents change

Side effects

  • N/A

Related changes

  • N/A

Copy link
Contributor

@cofyc cofyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 21cf119 into pingcap:master May 9, 2019
@AstroProfundis AstroProfundis deleted the validate-docs-minikube branch May 9, 2019 08:18
yahonda pushed a commit that referenced this pull request Dec 27, 2021
* Changed warning message about deleting PVs

* Update en/configure-storage-class.md

Co-authored-by: DanielZhangQD <[email protected]>

Co-authored-by: DanielZhangQD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants