drainer/* change more reasonable default config value #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/drainer/drainer.toml
Outdated
|
|
||
| # work count to execute binlogs | ||
| worker-count = 1 | ||
| # if the latency between drainer and downstream(mysql or tidb), you might want to increase this |
There was a problem hiding this comment.
if the latency between drainer and downstream(mysql or tidb)
this sentence is not smooth
IANTHEREAL
reviewed
Jan 7, 2019
| @@ -28,10 +28,12 @@ pd-urls = "http://127.0.0.1:2379" | |||
| ignore-schemas = "INFORMATION_SCHEMA,PERFORMANCE_SCHEMA,mysql" | |||
|
|
|||
| # number of binlog events in a transaction batch | |||
| txn-batch = 1 | |||
| txn-batch = 20 | |||
|
LGTM |
|
@WangXiangUSTC PTAL |
july2993
added a commit
that referenced
this pull request
Jan 22, 2019
* drainer/* change more reasonable default config value
july2993
added a commit
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
https://internal.pingcap.net/jira/browse/TOOL-803
What is changed and how it works?
change to more reasonable default value
Check List
Tests
Code changes
Side effects
Related changes