tidb-in-kubernetes: add permitHost document #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yikeke
reviewed
Aug 20, 2019
weekface
reviewed
Aug 22, 2019
| 2. 部署集群 | ||
| 2. 设置允许访问 TiDB 的主机 | ||
|
|
||
| 在部署集群前可以通过设置 `permitHost` 设置允许访问 TiDB 的主机 **host_name**。如果不设置，则允许所有主机访问。详情请参考 [Mysql GRANT host name](https://dev.mysql.com/doc/refman/5.7/en/grant.html)。 |
There was a problem hiding this comment.
Suggested change
| 在部署集群前可以通过设置 `permitHost` 设置允许访问 TiDB 的主机 **host_name**。如果不设置，则允许所有主机访问。详情请参考 [Mysql GRANT host name](https://dev.mysql.com/doc/refman/5.7/en/grant.html)。 | |
| 在部署集群前可以通过设置 `tidb.permitHost` 设置允许访问 TiDB 的主机 **host_name**。如果不设置，则允许所有主机访问。详情请参考 [Mysql GRANT host name](https://dev.mysql.com/doc/refman/5.7/en/grant.html)。 |
|
Please do not merge this pr before: pingcap/tidb-operator#779 |
Co-Authored-By: Keke Yi <[email protected]>
Co-Authored-By: Keke Yi <[email protected]>
Co-Authored-By: Keke Yi <[email protected]>
Co-Authored-By: weekface <[email protected]>
lilin90
changed the title
lilin90
reviewed
Sep 23, 2019
| @@ -33,9 +33,19 @@ category: how-to | |||
| kubectl create secret generic tidb-secret --from-literal=root=<root-password> --from-literal=developer=<developer-passowrd> --namespace=<namespace> | |||
| ``` | |||
|
|
|||
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。 | |||
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户`developer`默认只有`USAGE`权限，其他权限请在`tidb.initSql`中设置。 | |||
There was a problem hiding this comment.
Suggested change
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户`developer`默认只有`USAGE`权限，其他权限请在`tidb.initSql`中设置。 | |
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户 `developer` 默认只有 `USAGE` 权限，其他权限请在 `tidb.initSql` 中设置。 |
| @@ -34,9 +34,19 @@ aliases: ['/docs-cn/v3.0/how-to/configure/initialize-cluster/'] | |||
| kubectl create secret generic tidb-secret --from-literal=root=<root-password> --from-literal=developer=<developer-passowrd> --namespace=<namespace> | |||
| ``` | |||
|
|
|||
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。 | |||
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户developer默认只有USAGE权限，其他权限请在tidb.initSql中设置。 | |||
There was a problem hiding this comment.
- Keep the format consistent.
- Leave a space between Chinese and English characters.
Suggested change
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户developer默认只有USAGE权限，其他权限请在tidb.initSql中设置。 | |
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户 `developer` 默认只有 `USAGE` 权限，其他权限请在 `tidb.initSql` 中设置。 |
There was a problem hiding this comment.
Please address the comments from @lilin90, LGTM for the rest.
lilin90
reviewed
Oct 28, 2019
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。 | ||
| 该命令会创建 `root` 和 `developer` 两个用户的密码，存到 `tidb-secret` 的 Secret 里面。并且创建的普通用户developer默认只有USAGE权限，其他权限请在tidb.initSql中设置。 | ||
|
|
||
| 2. 设置允许访问 TiDB 的主机 |
There was a problem hiding this comment.
Suggested change
| 2. 设置允许访问 TiDB 的主机 | |
| 3. 设置允许访问 TiDB 的主机 |
| tidb: | ||
| passwordSecretName: tidb-secret | ||
| permitHost: <Mysql-client-host-name> | ||
| ``` | ||
|
|
||
| 3. 部署集群 |
There was a problem hiding this comment.
Suggested change
| 3. 部署集群 | |
| 4. 部署集群 |
junlan-zhang
added
translation/done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted?
tidb-in-kubernetes document: add permithost document.
What is the related PR or file link(s)?
pingcap/tidb-operator#733
Which version does your change affect?
tidb-operator v1.0 +