Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create index fix #433

Merged
merged 2 commits into from
Feb 13, 2022
Merged

Create index fix #433

merged 2 commits into from
Feb 13, 2022

Conversation

dantownsend
Copy link
Member

Fixes #431

When creating indexes, the column names need to be quoted in case they have problematic names like 'order'.

@dantownsend dantownsend added the bug Something isn't working label Feb 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #433 (2128a9c) into master (8500c81) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   90.84%   90.84%           
=======================================
  Files         103      103           
  Lines        6870     6870           
=======================================
  Hits         6241     6241           
  Misses        629      629           
Impacted Files Coverage Δ
piccolo/table.py 95.54% <ø> (ø)
piccolo/query/methods/create_index.py 97.05% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8500c81...2128a9c. Read the comment docs.

@dantownsend dantownsend merged commit 5f59841 into master Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

syntax error when adding index in migration
2 participants