-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show active instead of clients-ever-seen on the dashboard #2769
Conversation
…en the two numbers are different, show both Signed-off-by: DL6ER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should show the "total-ever seen clients". What is the use of knowing 612 clients have ever been on my network? With devices using random MAC, IPv6 prefix change and guests coming and going this number will only increase.
We also don't show the number of ever handled queries or ever blocked queries.
I think I agree with yubiuser. Dashboard only shows data (total queries, blocked queries, percentage, graphics, top lists) from the last 24 hours. |
Total clients, however, constantly eat up resources as we need to allocate DNS cache per-client as some clients may block a domains and others not (due to groups). This is not an issue for queries, upstreams, etc. which can come and go any not cause memory accumulation over time. If you see one million total clients, it may be a good idea to restart FTL. If you still think this should be removed, I'll do this. |
I'm not sure, if users are aware of those facts.
I still think so, but we can have a night in-between before making a decision. |
Signed-off-by: DL6ER <[email protected]>
What does this implement/fix?
Show active clients instead of clients-ever-seen on the dashboard:

When the two numbers are different, show both

This PR depends on the corresponding FTL branch being checked out: pi-hole/FTL#1688
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.