Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show active instead of clients-ever-seen on the dashboard #2769

Merged
merged 2 commits into from
Oct 22, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 21, 2023

What does this implement/fix?

Show active clients instead of clients-ever-seen on the dashboard:
Screenshot from 2023-10-21 18-45-55

When the two numbers are different, show both
image

This PR depends on the corresponding FTL branch being checked out: pi-hole/FTL#1688

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…en the two numbers are different, show both

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER added the Bugfix label Oct 21, 2023
@DL6ER DL6ER requested a review from a team October 21, 2023 16:46
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should show the "total-ever seen clients". What is the use of knowing 612 clients have ever been on my network? With devices using random MAC, IPv6 prefix change and guests coming and going this number will only increase.

We also don't show the number of ever handled queries or ever blocked queries.

@rdwebdesign
Copy link
Member

I think I agree with yubiuser.

Dashboard only shows data (total queries, blocked queries, percentage, graphics, top lists) from the last 24 hours.

@DL6ER
Copy link
Member Author

DL6ER commented Oct 21, 2023

Total clients, however, constantly eat up resources as we need to allocate DNS cache per-client as some clients may block a domains and others not (due to groups). This is not an issue for queries, upstreams, etc. which can come and go any not cause memory accumulation over time. If you see one million total clients, it may be a good idea to restart FTL.

If you still think this should be removed, I'll do this.

@yubiuser
Copy link
Member

Total clients, however, constantly eat up resources
If you see one million total clients, it may be a good idea to restart FTL.

I'm not sure, if users are aware of those facts.
The better solution to this would probably be a warning in the message system. (E.g. "Fom 1000 clients 900 haven't been seen in 90 days. Those still consume resources. Consider restarting FTL")

If you still think this should be removed, I'll do this.

I still think so, but we can have a night in-between before making a decision.

@DL6ER
Copy link
Member Author

DL6ER commented Oct 22, 2023

Possible compromise pushed (hover text):

Screenshot from 2023-10-22 09-23-18

@DL6ER DL6ER merged commit 48fd33b into development-v6 Oct 22, 2023
@DL6ER DL6ER deleted the fix/active_clients branch October 22, 2023 17:51
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants