Improve gravity parseLists on low-RAM systems #2320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Use
temp_store = FILE
to avoid memory exhaustion for a very large number of lists ingravity parseLists
. This is nothing else than extending the already merged pi-hole/pi-hole#5977 also to theparseList
feature. I did not expect this to be affected, too, however, if single lists already have multi-million domains on them, then this is a problem is your Pi-hole is having only 512 MB total RAM (or even less...).Related issue or feature (if applicable): Fixes #2194
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.