Prevent crash on failure to source secure randomness #2300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <[email protected]>
…or to application-wide scope Signed-off-by: DL6ER <[email protected]>
…m that is set during installation or boot) for random number generation initialization Signed-off-by: DL6ER <[email protected]>
…m() fails, we first try manually sourcing from /dev/urandom ourselves to exclude this being a simple library error. If this does not work either, we resort to using mbedtls' DRBG method. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
DL6ER
force-pushed
the
fix/randomness_crash
branch
from
b16d001 to
b943517
Compare
|
First success reports incoming on #2242 (comment), I will mark this as "ready for review". |
PromoFaux
previously approved these changes
Feb 28, 2025
yubiuser
reviewed
Mar 1, 2025
…avoid spamming user logs on systems which are permanently broken Signed-off-by: DL6ER <[email protected]>
|
Updated the PR description, assuming the approval still holds after demoting the print statements from |
This was referenced Mar 1, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Good entropy is the fundamental basis for good cryptography (DNSSEC, password hashing) and SSL or TLS. If your entropy is weak or predictable, a strong adversary can break your security. This PR adds two fallback layers in case secure (hardware) randomness is not available because the kernel is (a) too old or (b) the feature has actively been disabled. The last layer (an internal DRBG) should always work.
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase)Checklist:
developmentalbranch.