Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the role of dns.domain outside of the DHCP context #2239

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 21, 2025

What does this implement/fix?

See title and #2235 for additional context.

Related issue or feature (if applicable): Fixes #2235

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

yubiuser
yubiuser previously approved these changes Feb 21, 2025
@mwoolweaver
Copy link

mwoolweaver commented Feb 21, 2025

The DNS domain used by your Pi-hole.\n\n This DNS domain in purely local.

Should this say "domain is purely local"?

Signed-off-by: DL6ER <[email protected]>
@DL6ER
Copy link
Member Author

DL6ER commented Feb 22, 2025

I'm going to assume the approvals are still valid after fixing only a one-letter typo

@DL6ER DL6ER merged commit 619d837 into development Feb 22, 2025
19 checks passed
@DL6ER DL6ER deleted the fix/dns_domain_docs branch February 22, 2025 08:11
@yubiuser
Copy link
Member

web port PR pi-hole/web#3245

@DL6ER DL6ER mentioned this pull request Feb 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pi-Hole does not appear to be forwarding all requests to unbound upstream
3 participants