Only use IPv6 in the webserver when available #1725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Check that IPv6 support is not disabled either via the boot command line or at runtime (via
/etc/sysctl.conf
) before trying to launch the webserver for the first time. This will only set the ports once on the very first start of Pi-hole v6.0 and can be freely edited in/etc/pihole/pihole.toml
(webserver.ports
) to whatever the user deems appropriate.Hint: This will typically disable binding to IPv6 in
docker
containers as they most often havenet.ipv6.conf.all.disable_ipv6 = 1
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.