Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use IPv6 in the webserver when available #1725

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 2, 2023

What does this implement/fix?

Check that IPv6 support is not disabled either via the boot command line or at runtime (via /etc/sysctl.conf) before trying to launch the webserver for the first time. This will only set the ports once on the very first start of Pi-hole v6.0 and can be freely edited in /etc/pihole/pihole.toml (webserver.ports) to whatever the user deems appropriate.

Hint: This will typically disable binding to IPv6 in docker containers as they most often have net.ipv6.conf.all.disable_ipv6 = 1

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…r at runtime before trying to launch the webserver for the first time

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested a review from a team November 2, 2023 12:00
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/start-of-webserver-failed-web-interface-will-not-be-available/65545/8

@DL6ER DL6ER changed the title Only use Ipv6 in the webserver when available Only use IPv6 in the webserver when available Nov 2, 2023
@DL6ER DL6ER merged commit 7d50efc into development-v6 Nov 3, 2023
@DL6ER DL6ER deleted the tweak/test_ipv6 branch November 3, 2023 05:24
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants