Slash the slash

[DL6ER]

What does this implement/fix?

As a consequence of pi-hole/web#2655, redirection from the login page to any other page than the dashboard is broken.

This PR fixes this in the proper way by redirecting from URLs with trailing slashes such as /admin/queries/" to /admin/queries which is where the actual scripts are (they'd have to be in /admin/queries/index.html otherwise)

---

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A

---

By submitting this pull request, I confirm the following:

1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the EUPL 1.2 license
5. I have squashed any insignificant commits. (git rebase)

Checklist:

• The code change is tested and works locally.
• I based my code and PRs against the repositories developmental branch.
• I signed off all commits. Pi-hole enforces the DCO for all contributions
• I signed all my commits. Pi-hole requires signatures to verify authorship
• I have read the above and my PR is ready for review.

[PromoFaux]

Testing in a container - it appears the behaviour that was fixed by pi-hole/web#2655 is back

Visiting pi.hole/admin redirects to 172.20.2/admin/

[DL6ER]

Thanks for testing. We accidentally undid the "trick" we applied over there. My latest commit should fix this "once and for all" by handling all cases (ending or not in a slash) properly. Please test again

[PromoFaux]

Visiting pi.hole/admin redirects to 172.20.2/admin/

This is still the case for me

The other issue that I showed in the gif in mattermost earlier, however, is fixed

[DL6ER]

@PromoFaux I cannot reproduce this, but it might be a cache issue. Could you try again with another browser or her with the dev tools opened on the networks tab and selected to not load from cache?

[PromoFaux]

Same thing in an incognito window with cache disabled

If I'm logged out, it works... at least, I get redirected to 127.0.0.1/admin/login?target=%2admin

Once I log in, it takes me to 127.0.0.1/admin/

If I then manually remove the trailing slash you see the following behaviour:

[DL6ER]

I'm confused now, that is only happen when you manually remove the slash or does it also happen when you do something in the way it should be done? (No doubt we should get the manual removal of the slash fixed as well)

[PromoFaux]

Seemingly only when I do the manual remove of the slash. Imagine I am authenticated, and then open a new tab and type 127.0.0.1/admin - it should probably redirect

[yubiuser]

I can confirm, everything works as it should when used as one should use it. However, when I'm loggend in via hostname/admin/ and remove the trailing slash I get redirected to IP/login as unauthorized.

[DL6ER]

It should now be fixed. This last change actually made pi-hole/web#2655 completely redundant, however, it also doesn't hurt to have it.

[PromoFaux]

Confirmed with a local build that this is now working as expected, even when used as not expected.