Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI Authentication and Authorization details for the API #1588

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jul 13, 2023

What does this implement/fix?

See title, no functional change.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): This is the documentation change.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

DL6ER added 2 commits July 13, 2023 20:00
…ry endpoint except GET,POST /api/auth needs authentication

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER requested review from Bucking-Horn and a team July 13, 2023 18:15
@DL6ER
Copy link
Member Author

DL6ER commented Jul 13, 2023

https://ftl.pi-hole.net/openAPI/security/docs/#delete-/auth

No auth needed ✅

Screenshot from 2023-07-13 20-36-20

Auth needed ✅

Screenshot from 2023-07-13 20-36-31
Screenshot from 2023-07-13 20-36-37

@DL6ER DL6ER merged commit 13e3e67 into development-v6 Jul 14, 2023
@DL6ER DL6ER deleted the openAPI/security branch July 14, 2023 17:25
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants