Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit log #1450

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Fix audit log #1450

merged 2 commits into from
Oct 1, 2022

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 1, 2022

By submitting this pull request, I confirm the following:

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

How familiar are you with the codebase?:

10


Fix #1435 by changing the audit log SQL query. This is necessary as #1409 deprecated using SELECT EXISTS(...) to get domain IDs. This PR also adds a test to ensure this cannot happen again and be unnoticed.

@DL6ER DL6ER added the Bugfix label Oct 1, 2022
@DL6ER DL6ER linked an issue Oct 1, 2022 that may be closed by this pull request
@PromoFaux PromoFaux self-requested a review October 1, 2022 12:25
Copy link
Member

@PromoFaux PromoFaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed working

@DL6ER DL6ER merged commit 814db79 into development Oct 1, 2022
@DL6ER DL6ER deleted the fix/audit_log branch October 1, 2022 12:37
@suterma
Copy link

suterma commented Oct 8, 2022

Hi, is there a timeline, for when this gets into production? The audit log is one of the best features for me. I might switch to the devel branch, but not if a release is near. Thanks for the pi-hole so far anyway.

@yubiuser
Copy link
Member

yubiuser commented Oct 8, 2022

A release is near, but no fixed date yet: #1453

@suterma
Copy link

suterma commented Oct 18, 2022

Audit log is working for me again, with the most recent update. Many thanks for this useful tool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log empty in v5.15.
4 participants