Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New logging style #1141

Merged
merged 10 commits into from
May 28, 2021
Merged

New logging style #1141

merged 10 commits into from
May 28, 2021

Conversation

yubiuser
Copy link
Member

Please submit all pull requests against the development branch. Failure to do so will delay or deny your request

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

Change the logging mode to the new style

Signed-off-by: yubiuser <[email protected]>
@yubiuser yubiuser changed the title New logging common.c New logging style May 27, 2021
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have only a few suggestions.

Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an error.

@yubiuser
Copy link
Member Author

What am I doing with

if(config.debug & DEBUG_ARP && dbID >= 0)

Translates to

log_debug(DEBUG_ARP, ???????

@DL6ER
Copy link
Member

DL6ER commented May 27, 2021

This would be

if(dbID >= 0)
	log_debug(DEBUG_ARP, "...");

@yubiuser yubiuser marked this pull request as ready for review May 27, 2021 19:16
@DL6ER DL6ER merged commit dc820e5 into pi-hole:new/http_logging May 28, 2021
@yubiuser yubiuser deleted the new/http_logging branch May 28, 2021 09:22
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants