Skip to content

Add FreeBSD ZTS nightly build #18959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add FreeBSD ZTS nightly build #18959

wants to merge 3 commits into from
+21 −2

Conversation

arnaud-lb
Copy link
Member

@arnaud-lb arnaud-lb marked this pull request as ready for review June 27, 2025 12:43
@devnexen
Copy link
Member

Is the change in the extension necessary if you have these in the other PR ?

@arnaud-lb
Copy link
Member Author

I plan to rebase on master once the other PR is merged, so that only the first commit remains in this PR

@devnexen
Copy link
Member

Ok. maybe the build aspect deserves a review from @iluuu1994 ?

iluuu1994
iluuu1994 reviewed Jun 27, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target 8.1 for the changes to nightly, we keep the config in-sync. If this should only run for master (in case the pcntl change only targets master) we need to skip the ZTS build accordingly (only merging into master would not be sufficient either).

.github/workflows/nightly.yml Outdated
Comment on lines 1058 to 1060
include:
- zts: false
- zts: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include:
- zts: false
- zts: true
zts: [true, false]

@arnaud-lb arnaud-lb closed this in 85522c0 Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 left review comments

@TimWolla TimWolla TimWolla approved these changes

@devnexen devnexen Awaiting requested review from devnexen

Assignees
No one assigned
Labels
Extension: pcntl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arnaud-lb @devnexen @TimWolla @iluuu1994