Skip to content

RFC: Turn clone() into a function #18919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 24, 2025
Merged

RFC: Turn clone() into a function #18919

merged 14 commits into from
Jun 24, 2025

Conversation

TimWolla
Copy link
Member

This is necessary for `clone()` which does not currently accept a
parameter-less syntax, unless fully-qualified.
TimWolla added a commit to TimWolla/PHP-Parser that referenced this pull request Jun 23, 2025
nikic pushed a commit to nikic/PHP-Parser that referenced this pull request Jun 23, 2025
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my syntax remark. Otherwise seems fine mostly.

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions were answered and follow ups were proposed, so this LGTM

@TimWolla TimWolla merged commit ca49a7b into php:master Jun 24, 2025
9 checks passed
@TimWolla TimWolla deleted the clone-function branch June 24, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants