-
Notifications
You must be signed in to change notification settings - Fork 50
Fixed the documentation. #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,15 +20,15 @@ interface Hashable | |
* | ||
* @return mixed | ||
*/ | ||
function hash(); | ||
public function hash(); | ||
|
||
/** | ||
* Determines if two objects should be considered equal. Both objects will | ||
* be instances of the same class but may not be the same instance. | ||
* | ||
* @param $obj An instance of the same class to compare to. | ||
* @param $obj self An instance of the same class to compare to. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this is correct - it could be anything at all. See php-ds/ext-ds#140 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Man, I am so confused. I go down the same path as many of the commenters in that thread... First, I thought I can understand There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
😁 no problem, I was for a while too. The thing here is that The issue is that you can of course call There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Regardless of the correct type, it should precede the parameter name, not come after it. |
||
* | ||
* @return bool | ||
*/ | ||
function equals($obj): bool; | ||
public function equals($obj): bool; | ||
} |
Uh oh!
There was an error while loading. Please reload this page.