add go 1.22 build

[lizzzcai]

add go 1.22 build support to fix some vulnerabilities.

[igungor]

Now that we have Go 1.23.2, could you update your PR to

• use go 1.23.x in goreleaser and docker builds
• use 1.23.x, 1.22.x, and 1.21.x in github actions job matrices please? :)

[lizzzcai]

Now that we have Go 1.23.2, could you update your PR to

• use go 1.23.x in goreleaser and docker builds
• use 1.23.x, 1.22.x, and 1.21.x in github actions job matrices please? :)

Done. I assumed 1.19 and 1.20 are not needed anymore.

[igungor]

Now that we have Go 1.23.2, could you update your PR to

• use go 1.23.x in goreleaser and docker builds
• use 1.23.x, 1.22.x, and 1.21.x in github actions job matrices please? :)

Done. I assumed 1.19 and 1.20 are not needed anymore.

Correct. We test test latest 3 Go releases.

[igungor]

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.

I'd push the necessary changes but I don't have access to your repo.

Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

[lizzzcai]

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.

I'd push the necessary changes but I don't have access to your repo.

Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

[igungor]

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.
I'd push the necessary changes but I don't have access to your repo.
Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

Hmm, it may not be the time to add Go 1.23 to the build matrix :(

[lizzzcai]

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.
I'd push the necessary changes but I don't have access to your repo.
Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

Hmm, it may not be the time to add Go 1.23 to the build matrix :(

Hi @igungor , how about keep it to 1.22.x, 1.21.x and 1.20.x? Overall 1.22.x meets my requirements.

[igungor]

ci / qa (1.23.x, ubuntu) fails because staticcheck tool doesn't recognize a Go 1.23 feature yet. Updating honnef.co/go/tools to v0.6.0-0.dev fixes the issue.
I'd push the necessary changes but I don't have access to your repo.
Could you do the above version change in go.mod fileand run go mod tidy && go mod vendor please? This will bring the necessary changes. Please commit those changes and let's see if it's working.

Hi @igungor, by upgrading to honnef. com/go/tools v0.6.0-0.dev, the minimal Go version becomes 1.22.1.

Hmm, it may not be the time to add Go 1.23 to the build matrix :(

Hi @igungor , how about keep it to 1.22.x, 1.21.x and 1.20.x? Overall 1.22.x meets my requirements.

sounds good.

[lizzzcai]

Hi @igungor , updated. any timeline for fixing the timeout issue in new go version? and is there any plan to trigger a new release in the main branch (I saw a similar question #766)? Thanks.

[igungor]

Thanks. Increased s5cmd test command timeout to 10 minutes but the issue is still there. I'm not sure what the problem is on Go 1.21 macos test.

[lizzzcai]

Thanks. Increased s5cmd test command timeout to 10 minutes but the issue is still there. I'm not sure what the problem is on Go 1.21 macos test.

Hi @igungor , if I am not wrong, I think this line overwrite the timeout. Maybe I can just increase it or remove it?

[igungor]

Thanks. Increased s5cmd test command timeout to 10 minutes but the issue is still there. I'm not sure what the problem is on Go 1.21 macos test.

Hi @igungor , if I am not wrong, I think this line overwrite the timeout. Maybe I can just increase it or remove it?

It'd be great if you could remove the timeout line.

[igungor]

Thanks!

[vrdn-23]

@igungor @lizzzcai Now that the new version has been updated to docker, would it be possible to cut a new release so that we can pull it using the release tag?

[lizzzcai]

@igungor @lizzzcai Now that the new version has been updated to docker, would it be possible to cut a new release so that we can pull it using the release tag?

Hi @vrdn-23 , I am expecting a new release as well. Probably need to check with the maintainer on the plan.

[gkowarzyk]

Before a new release is cut, please also update the github.com/lanrat/extsort to v1.0.1 (see Issue #717). The change in this new version is a license change to a more permissive licence, which would make it easier to adopt s5cmd.
Thanks in advance!