-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cat: make it concurrent #593
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have reduced the test size in here. Line 24 in 5b55085
The reason for this is that since we have more test cases, we should aim to show that the feature/fix works while maintaining a reasonable time for the tests to run. Lines 50 to 75 in 5b55085
Lowering the file size and adjusting the partSize and concurrency on the tests both show the feature works correctly while maintaining a feasible duration for the test.
|
igungor
requested changes
Jul 24, 2023
seruman
reviewed
Jul 25, 2023
igungor
reviewed
Jul 26, 2023
seruman
requested changes
Jul 27, 2023
igungor
reviewed
Jul 27, 2023
igungor
reviewed
Jul 27, 2023
igungor
approved these changes
Jul 27, 2023
seruman
approved these changes
Jul 27, 2023
🥇 |
ahmethakanbesel
pushed a commit
to ahmethakanbesel/s5cmd
that referenced
this pull request
Jul 28, 2023
This PR adds a new io.WriterAt adapter for non-seekable writers. It uses an internal linked list to order the incoming chunks. The implementation is independent from the download manager of aws-sdk-go, and because of that currently it can not bound the memory usage. In order to limit the memory usage, we would have had to write a custom manager other than the aws-sdk-go's implementation, which seemed unfeasible. The new implementation is about %25 percent faster than the older implementation for a 9.4 GB file with partSize=50MB and concurrency=20 parameters, with significantly higher memory usage, on average it uses 0.9 GB of memory and at most 2.1 GB is observed. Obviously, the memory usage and performance is dependent on the partSize-concurrency configuration and the link. Resolves peak#245 Co-authored-by: İbrahim Güngör <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
io.WriterAt
adapter for non-seekable writers. It uses an internal linked list to order the incoming chunks. The implementation is independent from the download manager of aws-sdk-go, and because of that currently it can not bound the memory usage. In order to limit the memory usage, we would have had to write a custom manager other than the aws-sdk-go's implementation, which seemed unfeasible.The new implementation is about %25 percent faster than the older implementation for a 9.4 GB file with
partSize=50MB
andconcurrency=20
parameters, with significantly higher memory usage, on average it uses 0.9GB
of memory and at most 2.1GB
is observed. Obviously, the memory usage and performance is dependent on thepartSize
-concurrency
configuration and the link.Resolves #245.