Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

command: add --request-payer flag #383

Merged
merged 1 commit into from
Apr 7, 2022
Merged

command: add --request-payer flag #383

merged 1 commit into from
Apr 7, 2022

Conversation

Kirill888
Copy link
Contributor

allow access to requester pays buckets, issue #297

@Kirill888 Kirill888 requested a review from a team as a code owner November 26, 2021 09:23
@Kirill888 Kirill888 requested review from igungor and sonmezonur and removed request for a team November 26, 2021 09:23
sonmezonur
sonmezonur reviewed Dec 10, 2021
View reviewed changes
Copy link
Member

@sonmezonur sonmezonur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

Some of the storage operations ( Select(), Put(), Delete() etc.) do not use request-payer option. Could you add this option to all S3 operations/functions?

@Kirill888
Copy link
Contributor Author

Some of the storage operations ( Select(), Put(), Delete() etc.) do not use request-payer option. Could you add this option to all S3 operations/functions?

@sonmezonur thanks for looking into this, I have added RequestPayer options to Put() and Delete(), but Select() doesn't seem to have that option strangely, it's certainly not exposed in the SelectObjectContentInput struct, and there is no mention of that option in http api docs either.

@Kirill888 Kirill888 requested a review from sonmezonur December 16, 2021 01:34
@sonmezonur
Copy link
Member

@Kirill888 LGTM. Could you add an example for the usage of this option? Similar to examples in ls command

@Kirill888 Kirill888 force-pushed the master branch 2 times, most recently from 1284842 to 39e4235 Compare January 6, 2022 11:27
@Kirill888 Kirill888 requested a review from sonmezonur January 6, 2022 11:28
@sonmezonur
Copy link
Member

@Kirill888 could you resolve conflicts in your branch?

@sonmezonur
Copy link
Member

Sorry, 9d49411 is merged before and caused conflict. Could you rebase again? :)

@Kirill888
command: add --request-payer flag
5990f28 
allow access to requester pays buckets, issue peak#297
@sonmezonur sonmezonur merged commit 393df26 into peak:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonmezonur sonmezonur sonmezonur approved these changes

@igungor igungor Awaiting requested review from igungor igungor is a code owner automatically assigned from peak/big-data

@ilkinulas ilkinulas Awaiting requested review from ilkinulas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kirill888 @sonmezonur @ilkinulas