Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement s5cmd select #300

Merged
merged 13 commits into from
Jul 10, 2021
Merged

Implement s5cmd select #300

merged 13 commits into from
Jul 10, 2021

Conversation

skeggse
Copy link
Contributor

@skeggse skeggse commented Jun 16, 2021

Fixes #299.

skeggse
skeggse commented Jun 16, 2021
View reviewed changes
Copy link
Contributor Author

@skeggse skeggse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking for feedback on the right concurrency pattern, module import resolution, and maybe a little bit of error handling feedback. I've got some exposure to Go, but not a ton. Best practices that I'm missing are welcome.

@igungor
Copy link
Member

igungor commented Jun 18, 2021

Thanks for the PR and thorough comments! I'll try to review today.

igungor
igungor reviewed Jun 18, 2021
View reviewed changes
igungor
igungor reviewed Jun 18, 2021
View reviewed changes
ilkinulas
ilkinulas reviewed Jun 22, 2021
View reviewed changes
@skeggse skeggse requested a review from igungor June 23, 2021 17:22
igungor
igungor reviewed Jun 24, 2021
View reviewed changes
@igungor
Copy link
Member

igungor commented Jul 2, 2021

@skeggse Hi. Have you had time the time to look into this?

@skeggse
Copy link
Contributor Author

skeggse commented Jul 2, 2021

Hey, thanks for your patience! I'll try and take a look later today.

@skeggse skeggse force-pushed the implement-select branch from 982a376 to 672b7ac Compare July 6, 2021 17:22
@igungor
Copy link
Member

igungor commented Jul 7, 2021 •
edited
Loading

I think this PR is good to go. The only thing missing is the tests. Since gofakes3 package doesn't support SelectObject calls, I'm okay with this PR as it is.

@igungor igungor marked this pull request as ready for review July 7, 2021 07:50
@igungor igungor requested a review from a team as a code owner July 7, 2021 07:50
@igungor igungor requested review from ilkinulas and removed request for a team July 7, 2021 07:50
@ilkinulas
Copy link
Member

I am ok with this PR too, thank you @skeggse
Just a little request before merging it:

  • Let's add an example usage to README
  • And it would be good to add a note saying we only support json file format.

@skeggse
Copy link
Contributor Author

skeggse commented Jul 8, 2021

Updated to address @ilkinulas' comments!

ilkinulas
ilkinulas reviewed Jul 9, 2021
View reviewed changes
@skeggse @ilkinulas
docs: fix example query
3d3f72b 
Co-authored-by: İlkin Balkanay <[email protected]>
sonmezonur
sonmezonur reviewed Jul 9, 2021
View reviewed changes
@igungor igungor merged commit c2a9d31 into peak:master Jul 10, 2021
@igungor
Copy link
Member

igungor commented Jul 10, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igungor igungor igungor approved these changes

@ilkinulas ilkinulas ilkinulas approved these changes

@sonmezonur sonmezonur sonmezonur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SelectObjectContent support
4 participants
@skeggse @igungor @ilkinulas @sonmezonur