Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload to S3 always adds metadata "content-type: binary/octet-stream" instead of default per filetype. #33

Closed
johanwikstrom opened this issue Jan 21, 2020 · 1 comment · Fixed by #84
Assignees
Milestone

Comments

@johanwikstrom
Copy link

The question is, is there a way to control the metadata / contentype of the upload? It seem to default to upload as content-type: binary/octet-stream

The goal is to either be able to set the metadata content-type, or make s3 use the default content-type per filetype. When using the painfully slow aws cli, aws s3 cp or aws s3 sync it will automatically add a correct content type to metadata. This is critical for us that uses s3 to host websites.

I would be happy to look into a PR, but could use a hint or two to where to modify.

This could origin from the difference between using aws s3api and aws s3. I belive this tool is i using s3api?

@igungor
Copy link
Member

igungor commented Feb 24, 2020

Hi, thanks for the report, it definitely needs to be addressed. We'll let you know once it's implemented.

This could origin from the difference between using aws s3api and aws s3. I belive this tool is i using s3api?

This tool is written in Go. s5cmd uses the official AWS SDK.

@ilkinulas ilkinulas added this to the v1.0.0 milestone Mar 2, 2020
@igungor igungor self-assigned this Mar 2, 2020
igungor added a commit that referenced this issue Mar 2, 2020
WIP - DO NOT MERGE: needs tests

Fixes #33
igungor added a commit that referenced this issue Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants