Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: thread: Reference existing message when forwarding #1593

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

kbingham
Copy link
Contributor

When forwarding a mail, the outgoing mail, and any follow up
conversation becomes a disjointed thread. This removes the original
context, and makes it harder to find and track while the conversation
splits in two directions.

Add appropriate reference headers to the envelope when constructing a
forwarded mail to ensure that the conversations continue to be related
and therefore presented in the same thread with notmuch and alot.

Signed-off-by: Kieran Bingham [email protected]

When forwarding a mail, the outgoing mail, and any follow up
conversation becomes a disjointed thread.  This removes the original
context, and makes it harder to find and track while the conversation
splits in two directions.

Add appropriate reference headers to the envelope when constructing a
forwarded mail to ensure that the conversations continue to be related
and therefore presented in the same thread with notmuch and alot.

Signed-off-by: Kieran Bingham <[email protected]>
@kbingham
Copy link
Contributor Author

I think the 'references' header probably fixes my issue and keeps it in the correct thread, but looking at other mails I had received as forwards, I saw other clients adding the X-Forwarded-Message-Id: header, so I've introduced that as well. This may or may not be desired though.

Copy link
Owner

@pazz pazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this: joining these threads in the UI is better from a user perspective in my opinion and the patch you suggest has this effect for messages going forward.

@pazz pazz merged commit 6cd1b44 into pazz:master Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants