db: thread: Fix 'oldest subject' thread names #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notmuch2 bindings change now means the retrieval of the oldest
subject from a thread needs to be reworked.
When the config option is chosen to use the oldest subject:
# Set thread subjects to the first (oldest) message
thread_subject = oldest
The following error is generated:
File "/home/kbingham/iob/alot/alot/db/thread.py", line 50, in _refresh
first_msg = list(thread.get_toplevel_messages())[0]
AttributeError: 'Thread' object has no attribute 'get_toplevel_messages'
Update the code to use the correct interface on both the Thread and
Message objects.
Signed-off-by: Kieran Bingham <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notmuch2 bindings change now means the retrieval of the oldest
subject from a thread needs to be reworked.
When the config option is chosen to use the oldest subject:
The following error is generated:
Update the code to use the correct interface on both the Thread and
Message objects.