-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove support for .NET 6.0, 7.0 #396
feat: Remove support for .NET 6.0, 7.0 #396
Conversation
Thanks for opening this pull request!
|
This reverts commit 3be18e9.
BREAKING CHANGE: Removes support for .NET 6.0, 7.0 as they have reached their end-of-life date. |
add README for nuget
0764997
to
34db672
Compare
This reverts commit dbe3bc0.
When this passes. My new Request will to. Alternatively, you can accommodate for the request only as well. |
With this PR we'll target .NET 8 as the new min. version. This is currently on hold until the other PRs are merged, so that anyone still using .NET 6 or 7 can benefit from as many fixes in #402 as possible. If there are parts of the PR that are require min .NET 8, we'll merge them after this PR. That's a good example for why it would be great if you could split #40 into individual PRs. |
Done.
|
That sounds good; as mentioned above, I think we should merge (2) and (3) before this PR if that is easily possible; so you can leave the PR for (2) targeting .NET 6. |
@YBTopaz8 Do you think this is ready for merge? |
It is! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 48.00% 48.20% +0.19%
==========================================
Files 106 106
Lines 6199 6199
Branches 950 950
==========================================
+ Hits 2976 2988 +12
+ Misses 2910 2907 -3
+ Partials 313 304 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
48% code coverage? Great! |
Great, so merging this now... |
🎉 This change has been released in version 5.0.0 |
No description provided.