Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(op): remove redundant trait NetworkEthApi #8411

Merged
merged 1 commit into from
May 27, 2024
Merged

chore(op): remove redundant trait NetworkEthApi #8411

merged 1 commit into from
May 27, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented May 27, 2024

Removes redundant trait NetworkEthApi, which isn't needed since all EthApi return types are extensible:

  • AnyTransactionReceipt is alloy type WithOtherFields
  • Transaction already has a alloy type OtherFileds as a field
  • RichBlock is alloy type with field for extra info

@emhane emhane added C-debt A clean up/refactor of existing code A-op-reth Related to Optimism and op-reth labels May 27, 2024
@emhane emhane requested review from mattsse and Rjected as code owners May 27, 2024 13:12
@emhane emhane merged commit f4f7786 into matt/scaffold-ethapi May 27, 2024
6 of 27 checks passed
@emhane emhane deleted the emhane/eth-api branch May 27, 2024 13:21
@emhane emhane mentioned this pull request May 30, 2024
Closed
@emhane emhane mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-debt A clean up/refactor of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emhane @mattsse @DaniPopes