Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter by deposit signature hash #14841

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix: filter by deposit signature hash #14841

merged 1 commit into from
Mar 5, 2025

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Mar 5, 2025 •
edited
Loading

while the eip defines

Filtering events only by DEPOSIT_CONTRACT_ADDRESS
Deposit contract does not emit any events except for DepositEvent, thus additional filtering is unnecessary.

this isn't actually correct and we must filter logs by signature hash

@mattsse mattsse requested a review from Rjected as a code owner March 5, 2025 09:58
@rkrasiuk rkrasiuk mentioned this pull request Mar 5, 2025
Closed
@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior E-prague Related to the prague network upgrade labels Mar 5, 2025
joshieDo
joshieDo approved these changes Mar 5, 2025
View reviewed changes
@mattsse mattsse enabled auto-merge March 5, 2025 10:05
@mattsse mattsse added this pull request to the merge queue Mar 5, 2025
@mattsse mattsse removed this pull request from the merge queue due to a manual request Mar 5, 2025
@mattsse mattsse merged commit 80e86aa into main Mar 5, 2025
43 checks passed
@mattsse mattsse deleted the matt/filter-by-deposit-signature-hash branch March 5, 2025 10:17
mattsse added a commit that referenced this pull request Mar 5, 2025
@mattsse
fix: filter by deposit signature hash (#14841)
40b3c67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@DaniPopes DaniPopes DaniPopes approved these changes

@joshieDo joshieDo joshieDo approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
C-bug An unexpected or incorrect behavior E-prague Related to the prague network upgrade
Projects
Reth Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattsse @rkrasiuk @DaniPopes @joshieDo