Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce StatusEth69 for eth/69 status messages #14292

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Introduce StatusEth69 for eth/69 status messages #14292

merged 2 commits into from
Feb 10, 2025

Conversation

yohkaz
Copy link
Contributor

@yohkaz yohkaz commented Feb 7, 2025 •
edited
Loading

(potentially) Closes #12194

Continued with the option approach, but implemented a custom PartialEq in which:

Introducing StatusEth69 struct for eth/69 status messages, in which the total_difficulty field was dropped.

@yohkaz yohkaz marked this pull request as ready for review February 7, 2025 02:24
mattsse
mattsse requested changes Feb 8, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, looks like supporting both in one struct isn't super ideal -.- sorry about this

can we start by introducing a new struct StatusEth69 that is the same as status but doesn't have the totaldifficulty?

@mattsse mattsse added the A-networking Related to networking in general label Feb 8, 2025
@yohkaz yohkaz force-pushed the status-eth69-rlp-no-td branch from 204a725 to 9052b5d Compare February 8, 2025 12:57
@yohkaz
Copy link
Contributor Author

yohkaz commented Feb 8, 2025

@mattsse sure np : )
lmk if you first would like to just inctroduce the StatusEth69 struct by itself, or also the builder and traits impl. as I did in: 9052b5d

@yohkaz yohkaz changed the title Drop status td field in eth69 rlp encoding Introduce StatusEth69 for eth/69 status messages Feb 8, 2025
mattsse
mattsse requested changes Feb 8, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot better

a few more suggestions

like to just inctroduce the StatusEth69 struct by itself,

yep

@yohkaz yohkaz requested a review from mattsse February 9, 2025 00:23
mattsse
mattsse approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ty this should unblock us from adding eth69 support real quick once it's finalized

@mattsse mattsse added this pull request to the merge queue Feb 10, 2025
Merged via the queue into paradigmxyz:main with commit ecabf75 Feb 10, 2025
44 checks passed
18aaddy pushed a commit to 18aaddy/reth that referenced this pull request Feb 12, 2025
@yohkaz @18aaddy
Introduce StatusEth69 for eth/69 status messages (paradigmxyz#14292)
2eab100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-networking Related to networking in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support upcoming Eth69 Status message
2 participants
@yohkaz @mattsse